hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3594) WintuilsProcessStubExecutor.startStreamReader leaks streams
Date Fri, 22 May 2015 10:47:17 GMT

    [ https://issues.apache.org/jira/browse/YARN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555964#comment-14555964
] 

Junping Du commented on YARN-3594:
----------------------------------

+1. Patch LGTM. Committing this in.

> WintuilsProcessStubExecutor.startStreamReader leaks streams
> -----------------------------------------------------------
>
>                 Key: YARN-3594
>                 URL: https://issues.apache.org/jira/browse/YARN-3594
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.0.0
>            Reporter: Steve Loughran
>            Assignee: Lars Francke
>            Priority: Trivial
>              Labels: newbie
>         Attachments: YARN-3594.1.patch
>
>
> while looking at the file, my IDE highlights that the thread runnables started by 
> {{WintuilsProcessStubExecutor.startStreamReader()}} don't close their streams as they
exit.
> a java7 try-with-resources would trivially fix this



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message