hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3587) Fix the javadoc of DelegationTokenSecretManager in yarn project
Date Fri, 08 May 2015 22:42:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535791#comment-14535791
] 

Junping Du commented on YARN-3587:
----------------------------------

Thanks [~gliptak] for updating the patch. Latest patch LGTM. Also, I checked other reviewer's
comments in YARN-3599 get addressed as well. 
+1 pending on Jenkins result. It could be one line or 2 slightly longer than 80 characters
but if that is only complain together with no unit test, I should be fine.

> Fix the javadoc of DelegationTokenSecretManager in yarn project
> ---------------------------------------------------------------
>
>                 Key: YARN-3587
>                 URL: https://issues.apache.org/jira/browse/YARN-3587
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 2.7.0
>            Reporter: Akira AJISAKA
>            Assignee: Gabor Liptak
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-3587.1.patch, YARN-3587.patch
>
>
> In RMDelegationTokenSecretManager and TimelineDelegationTokenSecretManager,  the javadoc
of the constructor is as follows:
> {code}
>   /**
>    * Create a secret manager
>    * @param delegationKeyUpdateInterval the number of seconds for rolling new
>    *        secret keys.
>    * @param delegationTokenMaxLifetime the maximum lifetime of the delegation
>    *        tokens
>    * @param delegationTokenRenewInterval how often the tokens must be renewed
>    * @param delegationTokenRemoverScanInterval how often the tokens are scanned
>    *        for expired tokens
>    */
> {code}
> 1. "the number of seconds" should be "the number of milliseconds".
> 2. It's better to add time unit to the description of other parameters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message