hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3579) getLabelsToNodes in CommonNodeLabelsManager should support NodeLabel instead of label name as String
Date Fri, 08 May 2015 18:55:03 GMT

    [ https://issues.apache.org/jira/browse/YARN-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535259#comment-14535259
] 

Wangda Tan commented on YARN-3579:
----------------------------------

Hi Sunil,
Thanks for working on this, some comments:
- It seems to me getNodeIds is not necessary, even if it can avoid some duplications a little,
but it copies whole NodeId set, I think we'd better not to do that.
- getNodeLabelsInfo -> getNodeToLabelsInfo
- getNodeLabelsInfo: 1. better to check {{for (String label : nodeLabelNames) {}} if label
is NO_LABEL or not, only add label isn't NO_LABEL; 2. avoid adding nodeLabels when it's empty
before {{nodeToLabelsInfo.put(nodeId, nodeLabels);}}; 3. You can keep a reference of NodeLabel
in RMNodeLabel to avoid copy it everytime.
- Is it possible to merge getNodeLabels/getNodeToLabelsInfo and getLabelsInfoToNodes/getLabelsToNodes
using some generic type? Their logic are mostly same except one needs to get NodeLabel the
other one doesn't need.

> getLabelsToNodes in CommonNodeLabelsManager should support NodeLabel instead of label
name as String
> ----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3579
>                 URL: https://issues.apache.org/jira/browse/YARN-3579
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Sunil G
>            Assignee: Sunil G
>            Priority: Minor
>         Attachments: 0001-YARN-3579.patch
>
>
> CommonNodeLabelsManager#getLabelsToNodes returns label name as string. It is not passing
information such as Exclusivity etc back to REST interface apis.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message