hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-3565) NodeHeartbeatRequest/RegisterNodeManagerRequest should use NodeLabel object instead of String
Date Sat, 16 May 2015 02:49:00 GMT

     [ https://issues.apache.org/jira/browse/YARN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Naganarasimha G R updated YARN-3565:
------------------------------------
    Attachment: YARN-3565.20150516-1.patch

Hi [~wangda],
Uploading a patch with fixing applicable [~vinodkv] comments and ones which are not addressed
are :
* ??Not directly related to this patch, but in LabelsToNodeIdsProto?? : As discussed offline
will be handled in YARN-3583
* ??ResourceTrackerService shouldn't have convertToStringSet(). RMNodeLabelsManager.replaceLabelsOnNode()
etc.. should be modified to use the NodeLabel object??: As per the above [~wangda] comment
not required now.
* ??NodeReportProto also have a string for node_labels instead of an object.?? As discussed
offline will be handled in YARN-3583

> NodeHeartbeatRequest/RegisterNodeManagerRequest should use NodeLabel object instead of
String
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-3565
>                 URL: https://issues.apache.org/jira/browse/YARN-3565
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>            Priority: Blocker
>         Attachments: YARN-3565-20150502-1.patch, YARN-3565.20150515-1.patch, YARN-3565.20150516-1.patch
>
>
> Now NM HB/Register uses Set<String>, it will be hard to add new fields if we want
to support specifying NodeLabel type such as exclusivity/constraints, etc. We need to make
sure rolling upgrade works.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message