hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3529) Add miniHBase cluster and Phoenix support to ATS v2 unit tests
Date Mon, 11 May 2015 22:40:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538789#comment-14538789

Zhijie Shen commented on YARN-3529:

Thanks for the patch, Li! Some comments:

1. You should define the dependency version under {{./hadoop-project/pom.xml}}. And then you
can remove the version info like {{<version>$\{phoenix.version\}</version>}}

2. Do we need to all the following configurable not only in the unit test? At least, for POC,
do we need to config connString to point a real hbase cluster?
94	  @VisibleForTesting
95	  static String connString = "jdbc:phoenix:localhost:2181:/hbase";
96	  @VisibleForTesting
97	  static Properties connProperties = new Properties();

3. In TestPhoenixTimelineWriterImpl, shall we teardown the hbase cluster as well after dropping
the tables?

> Add miniHBase cluster and Phoenix support to ATS v2 unit tests
> --------------------------------------------------------------
>                 Key: YARN-3529
>                 URL: https://issues.apache.org/jira/browse/YARN-3529
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: AbstractMiniHBaseClusterTest.java, YARN-3529-YARN-2928.000.patch,
> After we have our HBase and Phoenix writer implementations, we may want to find a way
to set up HBase and Phoenix in our unit tests. We need to do this integration before the branch
got merged back to trunk. 

This message was sent by Atlassian JIRA

View raw message