hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3528) Tests with 12345 as hard-coded port break jenkins
Date Fri, 29 May 2015 12:22:19 GMT

    [ https://issues.apache.org/jira/browse/YARN-3528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564700#comment-14564700
] 

Steve Loughran commented on YARN-3528:
--------------------------------------

Port scan & allocate is how most other apps find ports, so I'm +1 on the idea.

regarding the sample code

# it should be something reusable by all tests, so placed in hadoop-core or its test utils
# on failure, the IOE should be rethrown. It may be a sign of a more fundamental problem
# you can use the java7 try-with-resources now

> Tests with 12345 as hard-coded port break jenkins
> -------------------------------------------------
>
>                 Key: YARN-3528
>                 URL: https://issues.apache.org/jira/browse/YARN-3528
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>         Environment: ASF Jenkins
>            Reporter: Steve Loughran
>            Assignee: Brahma Reddy Battula
>            Priority: Blocker
>              Labels: test
>
> A lot of the YARN tests have hard-coded the port 12345 for their services to come up
on.
> This makes it impossible to have scheduled or precommit tests to run consistently on
the ASF jenkins hosts. Instead the tests fail regularly and appear to get ignored completely.
> A quick grep of "12345" shows up many places in the test suite where this practise has
developed.
> * All {{BaseContainerManagerTest}} subclasses
> * {{TestNodeManagerShutdown}}
> * {{TestContainerManager}}
> + others
> This needs to be addressed through portscanning and dynamic port allocation. Please can
someone do this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message