hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kumar Vavilapalli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3523) Cleanup ResourceManagerAdministrationProtocol interface audience
Date Sun, 03 May 2015 21:03:06 GMT

    [ https://issues.apache.org/jira/browse/YARN-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526015#comment-14526015
] 

Vinod Kumar Vavilapalli commented on YARN-3523:
-----------------------------------------------

bq. Actually I'm not sure about what should be the correct audience setting for ResourceManagerAdministrationProtocol,
as a public API, it should be @Public. But actually, it will only used by RMAdminCLI, I don't
know is there any 3rd party projects writing their own "admin CLI" and implements IIRC,
I originally intended ResourceManagerAdministrationProtocol to be private. But folks put Public
annotation on the methods unfortunately.

I just checked the api docs, it doesn't seem to appear there. Can others confirm too? If confirmed,
we can simply mark everything as private.

> Cleanup ResourceManagerAdministrationProtocol interface audience
> ----------------------------------------------------------------
>
>                 Key: YARN-3523
>                 URL: https://issues.apache.org/jira/browse/YARN-3523
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>              Labels: newbie
>         Attachments: YARN-3523.20150422-1.patch
>
>
> I noticed ResourceManagerAdministrationProtocol has @Private audience for the class and
@Public audience for methods. It doesn't make sense to me. We should make class audience and
methods audience consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message