hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3523) Cleanup ResourceManagerAdministrationProtocol interface audience
Date Thu, 07 May 2015 01:03:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531823#comment-14531823
] 

Junping Du commented on YARN-3523:
----------------------------------

bq. Well my view is to have @Private at every method to avoid in future similar mistake as
currently happened. Thoughts?
OK. This should be fine also.
+1. Patch LGTM.


> Cleanup ResourceManagerAdministrationProtocol interface audience
> ----------------------------------------------------------------
>
>                 Key: YARN-3523
>                 URL: https://issues.apache.org/jira/browse/YARN-3523
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>              Labels: BB2015-05-TBR, newbie
>         Attachments: YARN-3523.20150422-1.patch, YARN-3523.20150504-1.patch, YARN-3523.20150505-1.patch
>
>
> I noticed ResourceManagerAdministrationProtocol has @Private audience for the class and
@Public audience for methods. It doesn't make sense to me. We should make class audience and
methods audience consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message