hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3513) Remove unused variables in ContainersMonitorImpl
Date Fri, 01 May 2015 22:53:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524215#comment-14524215
] 

Li Lu commented on YARN-3513:
-----------------------------

Hi [~Naganarasimha], thanks for the patch. +1 for removing {{vmemStillInUsage}} and {{pmemStillInUsage}}.
However, I noticed that we're using content in the 2928 branch. Since we're planning for a
branch merge, potentially soon, maybe it's fine to leave it there? 

> Remove unused variables in ContainersMonitorImpl
> ------------------------------------------------
>
>                 Key: YARN-3513
>                 URL: https://issues.apache.org/jira/browse/YARN-3513
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 2.8.0
>
>         Attachments: YARN-3513.20150421-1.patch
>
>
> class members :  {{private final Context context;}}
> and some local variables in MonitoringThread.run()  : {{vmemStillInUsage and pmemStillInUsage}}
are not used and just updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message