hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-3505) Node's Log Aggregation Report with SUCCEED should not cached in RMApps
Date Fri, 22 May 2015 18:47:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556601#comment-14556601
] 

Zhijie Shen edited comment on YARN-3505 at 5/22/15 6:46 PM:
------------------------------------------------------------

Are the followings the incompatible change: deleting the field and changing the type? /cc
[~xgong]

{code}
@@ -50,19 +50,13 @@ message NodeHeartbeatRequestProto {
   optional MasterKeyProto last_known_container_token_master_key = 2;
   optional MasterKeyProto last_known_nm_token_master_key = 3;
   optional StringArrayProto nodeLabels = 4;
-  repeated LogAggregationReportsForAppsProto log_aggregation_reports_for_apps = 5;
-}
{code}

{code}
 message LogAggregationReportProto {
-optional ApplicationIdProto application_id = 1;
-optional NodeIdProto node_id = 2;
-optional LogAggregationStatusProto log_aggregation_status = 3;
-optional string diagnostics = 4 [default = "N/A"];
+  optional ApplicationIdProto application_id = 1;
+  optional LogAggregationStatusProto log_aggregation_status = 2;
+  optional string diagnostics = 3 [default = "N/A"];
 }
{code}


was (Author: zjshen):
Are the followings the incompatible change: deleting the field and changing the type?

{code}
@@ -50,19 +50,13 @@ message NodeHeartbeatRequestProto {
   optional MasterKeyProto last_known_container_token_master_key = 2;
   optional MasterKeyProto last_known_nm_token_master_key = 3;
   optional StringArrayProto nodeLabels = 4;
-  repeated LogAggregationReportsForAppsProto log_aggregation_reports_for_apps = 5;
-}
{code}

{code}
 message LogAggregationReportProto {
-optional ApplicationIdProto application_id = 1;
-optional NodeIdProto node_id = 2;
-optional LogAggregationStatusProto log_aggregation_status = 3;
-optional string diagnostics = 4 [default = "N/A"];
+  optional ApplicationIdProto application_id = 1;
+  optional LogAggregationStatusProto log_aggregation_status = 2;
+  optional string diagnostics = 3 [default = "N/A"];
 }
{code}

> Node's Log Aggregation Report with SUCCEED should not cached in RMApps
> ----------------------------------------------------------------------
>
>                 Key: YARN-3505
>                 URL: https://issues.apache.org/jira/browse/YARN-3505
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: log-aggregation
>    Affects Versions: 2.8.0
>            Reporter: Junping Du
>            Assignee: Xuan Gong
>            Priority: Critical
>             Fix For: 2.8.0
>
>         Attachments: YARN-3505.1.patch, YARN-3505.2.patch, YARN-3505.2.rebase.patch,
YARN-3505.3.patch, YARN-3505.4.patch, YARN-3505.5.patch, YARN-3505.6.patch, YARN-3505.addendum.patch
>
>
> Per discussions in YARN-1402, we shouldn't cache all node's log aggregation reports in
RMApps for always, especially for those finished with SUCCEED.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message