hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3484) Fix up yarn top shell code
Date Tue, 05 May 2015 15:54:01 GMT

    [ https://issues.apache.org/jira/browse/YARN-3484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528701#comment-14528701
] 

Junping Du commented on YARN-3484:
----------------------------------

I won't get a chance to look at this (or any other non-bug bash related patches) until Friday.
Please do not commit it yet. I really don't want to open another jira to fix this again. Thanks.
Understand. Please take your time. I will leave this JIRA for you to review/commit. :)

> Fix up yarn top shell code
> --------------------------
>
>                 Key: YARN-3484
>                 URL: https://issues.apache.org/jira/browse/YARN-3484
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Varun Vasudev
>              Labels: newbie
>         Attachments: YARN-3484.001.patch, YARN-3484.002.patch
>
>
> We need to do some work on yarn top's shell code.
> a) Just checking for TERM isn't good enough.  We really need to check the return on tput,
especially since the output will not be a number but an error string which will likely blow
up the java code in horrible ways.
> b) All the single bracket tests should be double brackets to force the bash built-in.
> c) I'd think I'd rather see the shell portion in a function since it's rather large.
 This will allow for args, etc, to get local'ized and clean up the case statement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message