hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3276) Refactor and fix null casting in some map cast for TimelineEntity (old and new) and fix findbug warnings
Date Mon, 11 May 2015 12:56:01 GMT

    [ https://issues.apache.org/jira/browse/YARN-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537911#comment-14537911
] 

Junping Du commented on YARN-3276:
----------------------------------

Thanks [~zjshen] for review and comments!
bq. TimelineServiceUtils -> TimelineServiceHelper?
Sure. Will update it.

bq.  Is mapreduce using it? Maybe simply @Private
In my understanding, @Private could means it could be used by "Common", "HDFS", "MapReduce",
and "YARN", so it could be broader than current limitation? I didn't remove MapReduce here
as from other places, it seems we always keep MapReduce there as a practice even no obviously
reference from MR project. May be better to keep here as it is?

bq. TimelineEvent are not covered?
Nice catch! Will update it.

bq. AllocateResponsePBImpl change is not related?
Yes. There are several findbug warnings (this and change in TimelineMetric.java) involved
in previous patch on branch YARN-2928. I think it could be too overkill to file a separated
JIRA to fix this simple issues so I put the fix here and update the title a little bit. Make
sense?

> Refactor and fix null casting in some map cast for TimelineEntity (old and new) and fix
findbug warnings
> --------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3276
>                 URL: https://issues.apache.org/jira/browse/YARN-3276
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: YARN-3276-YARN-2928.v3.patch, YARN-3276-YARN-2928.v4.patch, YARN-3276-v2.patch,
YARN-3276-v3.patch, YARN-3276.patch
>
>
> Per discussion in YARN-3087, we need to refactor some similar logic to cast map to hashmap
and get rid of NPE issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message