hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3276) Refactor and fix null casting in some map cast for TimelineEntity (old and new)
Date Fri, 08 May 2015 01:44:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533742#comment-14533742
] 

Hadoop QA commented on YARN-3276:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 48s | Pre-patch YARN-2928 compilation is healthy.
|
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new
or modified test files. |
| {color:green}+1{color} | javac |   7m 37s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 54s | There were no new javadoc warning messages.
|
| {color:red}-1{color} | release audit |   1m 23s | The applied patch generated 13 release
audit warnings. |
| {color:red}-1{color} | checkstyle |   1m 16s | The applied patch generated  3 new checkstyle
issues (total was 76, now 79). |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 2  line(s) that end in whitespace.
Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse.
|
| {color:red}-1{color} | findbugs |   2m 56s | The patch appears to introduce 4 new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | yarn tests |   0m 22s | Tests passed in hadoop-yarn-api. |
| {color:green}+1{color} | yarn tests |   1m 57s | Tests passed in hadoop-yarn-common. |
| | |  42m 37s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-yarn-api |
|  |  org.apache.hadoop.yarn.api.records.timelineservice.TimelineMetric$1.compare(Long, Long)
negates the return value of Long.compareTo(Long)  At TimelineMetric.java:value of Long.compareTo(Long)
 At TimelineMetric.java:[line 47] |
| FindBugs | module:hadoop-yarn-common |
|  |  Inconsistent synchronization of org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl.builder;
locked 92% of time  Unsynchronized access at AllocateResponsePBImpl.java:92% of time  Unsynchronized
access at AllocateResponsePBImpl.java:[line 391] |
|  |  Inconsistent synchronization of org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl.proto;
locked 94% of time  Unsynchronized access at AllocateResponsePBImpl.java:94% of time  Unsynchronized
access at AllocateResponsePBImpl.java:[line 391] |
|  |  Inconsistent synchronization of org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl.viaProto;
locked 94% of time  Unsynchronized access at AllocateResponsePBImpl.java:94% of time  Unsynchronized
access at AllocateResponsePBImpl.java:[line 391] |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12731302/YARN-3276-YARN-2928.v3.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / d4a2362 |
| Release Audit | https://builds.apache.org/job/PreCommit-YARN-Build/7786/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| checkstyle |  https://builds.apache.org/job/PreCommit-YARN-Build/7786/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
|
| whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/7786/artifact/patchprocess/whitespace.txt
|
| Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/7786/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-api.html
|
| Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/7786/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
|
| hadoop-yarn-api test log | https://builds.apache.org/job/PreCommit-YARN-Build/7786/artifact/patchprocess/testrun_hadoop-yarn-api.txt
|
| hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/7786/artifact/patchprocess/testrun_hadoop-yarn-common.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7786/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7786/console |


This message was automatically generated.

> Refactor and fix null casting in some map cast for TimelineEntity (old and new)
> -------------------------------------------------------------------------------
>
>                 Key: YARN-3276
>                 URL: https://issues.apache.org/jira/browse/YARN-3276
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: YARN-3276-YARN-2928.v3.patch, YARN-3276-v2.patch, YARN-3276-v3.patch,
YARN-3276.patch
>
>
> Per discussion in YARN-3087, we need to refactor some similar logic to cast map to hashmap
and get rid of NPE issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message