hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2454) The function compareTo of variable UNBOUNDED in org.apache.hadoop.yarn.util.resource.Resources is definited wrong.
Date Fri, 01 May 2015 23:54:06 GMT

    [ https://issues.apache.org/jira/browse/YARN-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524327#comment-14524327
] 

Junping Du commented on YARN-2454:
----------------------------------

Patch LGTM. Kick off Jenkins again, +1 based on Jenkins' results.

> The function compareTo of variable UNBOUNDED in org.apache.hadoop.yarn.util.resource.Resources
is definited wrong.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2454
>                 URL: https://issues.apache.org/jira/browse/YARN-2454
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.4.0, 2.5.0, 2.4.1
>            Reporter: Xu Yang
>            Assignee: Xu Yang
>         Attachments: YARN-2454 -v2.patch, YARN-2454-patch.diff, YARN-2454.patch
>
>
> The variable UNBOUNDED implement the abstract class Resources, and override the function
compareTo. But there is something wrong in this function. We should not compare resources
with zero as the same as the variable NONE. We should change 0 to Integer.MAX_VALUE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message