hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2369) Environment variable handling assumes values should be appended
Date Fri, 01 May 2015 21:35:07 GMT

    [ https://issues.apache.org/jira/browse/YARN-2369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524003#comment-14524003
] 

Hadoop QA commented on YARN-2369:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 39s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 31s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 34s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does not increase
the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   2m 21s | The applied patch generated  7 new checkstyle
issues (total was 176, now 182). |
| {color:red}-1{color} | checkstyle |   3m  0s | The applied patch generated  12 new checkstyle
issues (total was 211, now 223). |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 13  line(s) that end in whitespace.
Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   5m 22s | The patch does not introduce any new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | common tests |  22m 29s | Tests passed in hadoop-common. |
| {color:green}+1{color} | mapreduce tests |   0m 45s | Tests passed in hadoop-mapreduce-client-common.
|
| {color:green}+1{color} | yarn tests |   0m 21s | Tests passed in hadoop-yarn-api. |
| {color:green}+1{color} | yarn tests |   1m 56s | Tests passed in hadoop-yarn-common. |
| | |  68m 23s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12729597/YARN-2369-2.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 3393461 |
| checkstyle |  https://builds.apache.org/job/PreCommit-YARN-Build/7574/artifact/patchprocess/diffcheckstylehadoop-common.txt
https://builds.apache.org/job/PreCommit-YARN-Build/7574/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
|
| whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/7574/artifact/patchprocess/whitespace.txt
|
| hadoop-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/7574/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-mapreduce-client-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/7574/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt
|
| hadoop-yarn-api test log | https://builds.apache.org/job/PreCommit-YARN-Build/7574/artifact/patchprocess/testrun_hadoop-yarn-api.txt
|
| hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/7574/artifact/patchprocess/testrun_hadoop-yarn-common.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7574/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7574/console |


This message was automatically generated.

> Environment variable handling assumes values should be appended
> ---------------------------------------------------------------
>
>                 Key: YARN-2369
>                 URL: https://issues.apache.org/jira/browse/YARN-2369
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: Jason Lowe
>            Assignee: Dustin Cote
>         Attachments: YARN-2369-1.patch, YARN-2369-2.patch
>
>
> When processing environment variables for a container context the code assumes that the
value should be appended to any pre-existing value in the environment.  This may be desired
behavior for handling path-like environment variables such as PATH, LD_LIBRARY_PATH, CLASSPATH,
etc. but it is a non-intuitive and harmful way to handle any variable that does not have path-like
semantics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message