hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remus Rusanu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1971) WindowsLocalWrapperScriptBuilder does not check for errors in generated script
Date Mon, 04 May 2015 07:19:06 GMT

    [ https://issues.apache.org/jira/browse/YARN-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526344#comment-14526344
] 

Remus Rusanu commented on YARN-1971:
------------------------------------

The problem is that there is no error check in the generated script. For comparison the ContainerLaunch.WindowsShellScriptBuilder
will check each line in the generated script by adding this line automatically in the script,
after each command:
{code}
@if %errorlevel% neq 0 exit /b %errorlevel%
{code}

I'm not advocating checking for various error conditions before launching the script, I'm
saying the generated script itself should have error checking and handling.

> WindowsLocalWrapperScriptBuilder does not check for errors in generated script
> ------------------------------------------------------------------------------
>
>                 Key: YARN-1971
>                 URL: https://issues.apache.org/jira/browse/YARN-1971
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Remus Rusanu
>            Assignee: Remus Rusanu
>            Priority: Minor
>
> Similar to YARN-1865. The DefaultContainerExecutor.WindowsLocalWrapperScriptBuilder builds
a shell script that contains commands that potentially may fail:
> {code}
> pout.println("@echo " + containerIdStr + " > " + normalizedPidFile +".tmp");
> pout.println("@move /Y " + normalizedPidFile + ".tmp " + normalizedPidFile); 
> {code}
> These can fail due to access permissions, disc out of space, bad hardware, cosmic rays
etc etc. There should be proper error checking to ease troubleshooting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message