hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1832) wrong MockLocalizerStatus.equals() method implementation
Date Thu, 07 May 2015 23:03:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533566#comment-14533566
] 

Hadoop QA commented on YARN-1832:
---------------------------------

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |   5m 18s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  1s | The patch appears to include 1 new
or modified test files. |
| {color:green}+1{color} | javac |   7m 43s | There were no new javac warning messages. |
| {color:green}+1{color} | release audit |   0m 20s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 39s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   1m  3s | The patch does not introduce any new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | yarn tests |   5m 53s | Tests passed in hadoop-yarn-server-nodemanager.
|
| | |  23m  9s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12634678/YARN-1832.patch |
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / 4d9f9e5 |
| hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/7783/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7783/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7783/console |


This message was automatically generated.

> wrong MockLocalizerStatus.equals() method implementation
> --------------------------------------------------------
>
>                 Key: YARN-1832
>                 URL: https://issues.apache.org/jira/browse/YARN-1832
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.2.0
>            Reporter: Hong Zhiguo
>            Assignee: Hong Zhiguo
>            Priority: Trivial
>              Labels: BB2015-05-TBR
>         Attachments: YARN-1832.patch
>
>
> "return getLocalizerId().equals(other) && ...;" should be
> "return getLocalizerId().equals(other. getLocalizerId()) && ...;"
> getLocalizerId() returns String. It's expected to compare this.getLocalizerId() against
other.getLocalizerId().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message