hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1832) wrong MockLocalizerStatus.equals() method implementation
Date Thu, 07 May 2015 21:55:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533457#comment-14533457
] 

Li Lu commented on YARN-1832:
-----------------------------

This patch still applies to the latest trunk (as of now). LGTM. 

> wrong MockLocalizerStatus.equals() method implementation
> --------------------------------------------------------
>
>                 Key: YARN-1832
>                 URL: https://issues.apache.org/jira/browse/YARN-1832
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.2.0
>            Reporter: Hong Zhiguo
>            Assignee: Hong Zhiguo
>            Priority: Trivial
>              Labels: BB2015-05-TBR
>         Attachments: YARN-1832.patch
>
>
> "return getLocalizerId().equals(other) && ...;" should be
> "return getLocalizerId().equals(other. getLocalizerId()) && ...;"
> getLocalizerId() returns String. It's expected to compare this.getLocalizerId() against
other.getLocalizerId().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message