hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1426) YARN Components need to unregister their beans upon shutdown
Date Fri, 22 May 2015 14:16:17 GMT

    [ https://issues.apache.org/jira/browse/YARN-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556183#comment-14556183
] 

Junping Du commented on YARN-1426:
----------------------------------

Thanks [~jeagles] for delivering the patch! The patch LGTM overall. 
Just one minor issues:
{code}
-      new RMNMInfo(rmContext, scheduler);
+      rmNMInfo = new RMNMInfo(rmContext, scheduler);
+      rmNMInfo.registerMBean();
{code}
I think we may prefer to move "rmNMInfo.registerMBean();" to serviceStart() instead of serviceInit().
Theoretically, serviceStop() should undo things we did in serviceStart(). Isn't it?

> YARN Components need to unregister their beans upon shutdown
> ------------------------------------------------------------
>
>                 Key: YARN-1426
>                 URL: https://issues.apache.org/jira/browse/YARN-1426
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: YARN-1426.2.patch, YARN-1426.patch, YARN-1426.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message