Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4D51E17C4D for ; Thu, 23 Apr 2015 16:28:44 +0000 (UTC) Received: (qmail 11140 invoked by uid 500); 23 Apr 2015 16:28:39 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 11100 invoked by uid 500); 23 Apr 2015 16:28:39 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 11087 invoked by uid 99); 23 Apr 2015 16:28:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2015 16:28:39 +0000 Date: Thu, 23 Apr 2015 16:28:39 +0000 (UTC) From: "Jason Lowe (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3537) NPE when NodeManager.serviceInit fails and stopRecoveryStore invoked MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509303#comment-14509303 ] Jason Lowe commented on YARN-3537: ---------------------------------- If the store is not null then we want to close it regardless of whether the context is null or not, because that means we opened it earlier. My previous point is that if we don't have a store then this method has nothing to do. If the context is null but the store isn't then there _is_ something that still needs to be done. > NPE when NodeManager.serviceInit fails and stopRecoveryStore invoked > -------------------------------------------------------------------- > > Key: YARN-3537 > URL: https://issues.apache.org/jira/browse/YARN-3537 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 2.7.0 > Reporter: Brahma Reddy Battula > Assignee: Brahma Reddy Battula > Attachments: YARN-3537-002.patch, YARN-3537.patch > > > 2015-04-23 19:30:34,961 INFO [main] service.AbstractService (AbstractService.java:noteFailure(272)) - Service NodeManager failed in state STOPPED; cause: java.lang.NullPointerException > java.lang.NullPointerException > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.stopRecoveryStore(NodeManager.java:181) > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceStop(NodeManager.java:326) > at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221) > at org.apache.hadoop.yarn.server.nodemanager.TestNodeManagerShutdown.tearDown(TestNodeManagerShutdown.java:106) -- This message was sent by Atlassian JIRA (v6.3.4#6332)