Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 407EE18F08 for ; Fri, 24 Apr 2015 11:35:42 +0000 (UTC) Received: (qmail 50149 invoked by uid 500); 24 Apr 2015 11:35:42 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 50102 invoked by uid 500); 24 Apr 2015 11:35:42 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 50089 invoked by uid 99); 24 Apr 2015 11:35:42 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Apr 2015 11:35:42 +0000 Date: Fri, 24 Apr 2015 11:35:41 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3522) DistributedShell uses the wrong user to put timeline data MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510840#comment-14510840 ] Hudson commented on YARN-3522: ------------------------------ FAILURE: Integrated in Hadoop-Hdfs-trunk #2105 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2105/]) YARN-3522. Fixed DistributedShell to instantiate TimeLineClient as the correct user. Contributed by Zhijie Shen (jianhe: rev aa4a192feb8939353254d058c5f81bddbd0335c0) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/TimelineClient.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSFailedAppMaster.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java > DistributedShell uses the wrong user to put timeline data > --------------------------------------------------------- > > Key: YARN-3522 > URL: https://issues.apache.org/jira/browse/YARN-3522 > Project: Hadoop YARN > Issue Type: Bug > Components: timelineserver > Reporter: Zhijie Shen > Assignee: Zhijie Shen > Priority: Blocker > Fix For: 2.7.1 > > Attachments: YARN-3522.1.patch, YARN-3522.2.patch, YARN-3522.3.patch > > > YARN-3287 breaks the timeline access control of distributed shell. In distributed shell AM: > {code} > if (conf.getBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED, > YarnConfiguration.DEFAULT_TIMELINE_SERVICE_ENABLED)) { > // Creating the Timeline Client > timelineClient = TimelineClient.createTimelineClient(); > timelineClient.init(conf); > timelineClient.start(); > } else { > timelineClient = null; > LOG.warn("Timeline service is not enabled"); > } > {code} > {code} > ugi.doAs(new PrivilegedExceptionAction() { > @Override > public TimelinePutResponse run() throws Exception { > return timelineClient.putEntities(entity); > } > }); > {code} > YARN-3287 changes the timeline client to get the right ugi at serviceInit, but DS AM still doesn't use submitter ugi to init timeline client, but use the ugi for each put entity call. It result in the wrong user of the put request. -- This message was sent by Atlassian JIRA (v6.3.4#6332)