Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A4FED17E92 for ; Sat, 18 Apr 2015 00:10:59 +0000 (UTC) Received: (qmail 4297 invoked by uid 500); 18 Apr 2015 00:10:59 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 4249 invoked by uid 500); 18 Apr 2015 00:10:59 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 4238 invoked by uid 99); 18 Apr 2015 00:10:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Apr 2015 00:10:59 +0000 Date: Sat, 18 Apr 2015 00:10:59 +0000 (UTC) From: "Jian He (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3463) Integrate OrderingPolicy Framework with CapacityScheduler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3463?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14500= 937#comment-14500937 ]=20 Jian He commented on YARN-3463: ------------------------------- - this.schedulableEntities !=3D null can never happen? since each time it= =E2=80=99s re-creating a new Ordering class. I think we can just initialize= {{this.comparator}} and {{this.schedulableEntities}} inside FifoOrderingPo= licy constructor and remove the setComparator method {code} if (this.schedulableEntities !=3D null) {=E2=80=A8 schedulableEntities.add= All(this.schedulableEntities);=E2=80=A8} {code} - this should be inside the {removed} check ? otherwise any unknown contain= er completed will cause reordering=20 {code} orderingPolicy.containerReleased(application, rmContainer); {code} - getStatusMessage -> getInfo ? > Integrate OrderingPolicy Framework with CapacityScheduler > --------------------------------------------------------- > > Key: YARN-3463 > URL: https://issues.apache.org/jira/browse/YARN-3463 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacityscheduler > Reporter: Craig Welch > Assignee: Craig Welch > Attachments: YARN-3463.50.patch, YARN-3463.61.patch, YARN-3463.64= .patch, YARN-3463.65.patch, YARN-3463.66.patch, YARN-3463.67.patch, YARN-34= 63.68.patch > > > Integrate the OrderingPolicy Framework with the CapacityScheduler -- This message was sent by Atlassian JIRA (v6.3.4#6332)