Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 312D317802 for ; Wed, 8 Apr 2015 11:35:16 +0000 (UTC) Received: (qmail 2220 invoked by uid 500); 8 Apr 2015 11:35:16 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 2178 invoked by uid 500); 8 Apr 2015 11:35:16 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 2166 invoked by uid 99); 8 Apr 2015 11:35:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Apr 2015 11:35:15 +0000 Date: Wed, 8 Apr 2015 11:35:15 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3457) NPE when NodeManager.serviceInit fails and stopRecoveryStore called MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485107#comment-14485107 ] Hudson commented on YARN-3457: ------------------------------ FAILURE: Integrated in Hadoop-Hdfs-trunk #2089 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2089/]) YARN-3457. NPE when NodeManager.serviceInit fails and stopRecoveryStore called. Contributed by Bibin A Chundatt. (ozawa: rev dd852f5b8c8fe9e52d15987605f36b5b60f02701) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java > NPE when NodeManager.serviceInit fails and stopRecoveryStore called > ------------------------------------------------------------------- > > Key: YARN-3457 > URL: https://issues.apache.org/jira/browse/YARN-3457 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Reporter: Bibin A Chundatt > Assignee: Bibin A Chundatt > Priority: Minor > Fix For: 2.8.0 > > Attachments: YARN-3457.001.patch > > > When NodeManager service init fails during stopRecoveryStore null pointer exception is thrown > {code} > @Override > protected void serviceInit(Configuration conf) throws Exception { > .. > try { > exec.init(); > } catch (IOException e) { > throw new YarnRuntimeException("Failed to initialize container executor", e); > } > this.context = createNMContext(containerTokenSecretManager, > nmTokenSecretManager, nmStore); > > {code} > context is null when service init fails > {code} > private void stopRecoveryStore() throws IOException { > nmStore.stop(); > if (context.getDecommissioned() && nmStore.canRecover()) { > .. > } > } > {code} > Null pointer exception thrown > {quote} > 015-04-07 17:31:45,807 WARN org.apache.hadoop.service.AbstractService: When stopping the service NodeManager : java.lang.NullPointerException > java.lang.NullPointerException > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.stopRecoveryStore(NodeManager.java:168) > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceStop(NodeManager.java:280) > at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221) > at org.apache.hadoop.service.ServiceOperations.stop(ServiceOperations.java:52) > at org.apache.hadoop.service.ServiceOperations.stopQuietly(ServiceOperations.java:80) > at org.apache.hadoop.service.AbstractService.init(AbstractService.java:171) > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.initAndStartNodeManager(NodeManager.java:484) > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.main(NodeManager.java:534) > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332)