Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B3A717A9A for ; Tue, 14 Apr 2015 21:52:59 +0000 (UTC) Received: (qmail 15027 invoked by uid 500); 14 Apr 2015 21:52:59 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 14984 invoked by uid 500); 14 Apr 2015 21:52:59 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 14972 invoked by uid 99); 14 Apr 2015 21:52:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Apr 2015 21:52:59 +0000 Date: Tue, 14 Apr 2015 21:52:59 +0000 (UTC) From: "Wangda Tan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (YARN-3354) Container should contains node-labels asked by original ResourceRequests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3354?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] Wangda Tan updated YARN-3354: ----------------------------- Attachment: YARN-3354.2.patch Thanks [~jianhe] for review! bq. setRequiredNodeLabelExpression -> nodeLabelExpression Done bq. NMContainerStatus#getRequiredNodeLabelExpression returns =E2=80=9C=E2= =80=9D by default, but ContainerTokenIdentifier#getRequiredNodeLabelExpress= ion returns NO_LABEL; RMContainerImpl#getRequiredlNodeLabelExpression retur= ns NO_LABEL; - we may just return =E2=80=9C=E2=80=9D for default Now makes them return NO_LABEL, since NO_LABEL is the default value for emp= ty-node-label-expression as well bq. Test case: add validation for the recovered resourceUsage. Done bq. proto file change is missing. Done Attached new patch, ver.2 > Container should contains node-labels asked by original ResourceRequests > ------------------------------------------------------------------------ > > Key: YARN-3354 > URL: https://issues.apache.org/jira/browse/YARN-3354 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, capacityscheduler, nodemanager, resourcemanager > Reporter: Wangda Tan > Assignee: Wangda Tan > Attachments: YARN-3354.1.patch, YARN-3354.2.patch > > > We proposed non-exclusive node labels in YARN-3214, makes non-labeled res= ource requests can be allocated on labeled nodes which has idle resources. > To make preemption work, we need know an allocated container's original n= ode label: when labeled resource requests comes back, we need kill non-labe= led containers running on labeled nodes. > This requires add node-labels in Container, and also, NM need store this = information and send back to RM when RM restart to recover original contain= er. -- This message was sent by Atlassian JIRA (v6.3.4#6332)