hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3523) Cleanup ResourceManagerAdministrationProtocol interface audience
Date Wed, 22 Apr 2015 12:10:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506959#comment-14506959
] 

Hadoop QA commented on YARN-3523:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 31s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | javac |   7m 32s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 34s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   3m 55s | There were no new checkstyle issues. |
| {color:green}+1{color} | install |   1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   1m 21s | The patch does not introduce any new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | yarn tests |   0m 23s | Tests passed in hadoop-yarn-api. |
| | |  39m 48s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12727198/YARN-3523.20150422-1.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / b08908a |
| hadoop-yarn-api test log | https://builds.apache.org/job/PreCommit-YARN-Build/7445/artifact/patchprocess/testrun_hadoop-yarn-api.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7445/testReport/ |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7445//console |


This message was automatically generated.

> Cleanup ResourceManagerAdministrationProtocol interface audience
> ----------------------------------------------------------------
>
>                 Key: YARN-3523
>                 URL: https://issues.apache.org/jira/browse/YARN-3523
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>             Fix For: 2.8.0
>
>         Attachments: YARN-3523.20150422-1.patch
>
>
> I noticed ResourceManagerAdministrationProtocol has @Private audience for the class and
@Public audience for methods. It doesn't make sense to me. We should make class audience and
methods audience consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message