hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3521) Support return structured NodeLabel objects in REST API when call getClusterNodeLabels
Date Wed, 29 Apr 2015 20:58:06 GMT

    [ https://issues.apache.org/jira/browse/YARN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520226#comment-14520226
] 

Wangda Tan commented on YARN-3521:
----------------------------------

Hi Sunil,
Thanks for working on this, some comments:

NodelabelsInfo: (It should be NodeLabelInfo, right?)
- nodeLabelName: don't need call {{new String()}} since it will be always initialized, and
I prefer to call it "name"
- nodeLabelExclusivity -> exclusivity
- Also getter
- Setters are not used by anybody, could be removed 
- I'm not sure if you need add an empty constructure to make {{// JAXB needs this}} like other
infos?
- Could add a constructor of NodeLabelsInfo receives NodeLabel which will be used by RMWebServices
- We may need to add a separated NodeLabelsInfo and it contains ArrayList of NodeLabelInfo

NodeToLabelsInfo -> NodeToLabelNames

addToClusterNodeLabels now receives Set as parameter, I'm not sure if it works, could you
add test to verify add/get node labels? Now TestRMWebServicesNodeLabels will fail

> Support return structured NodeLabel objects in REST API when call getClusterNodeLabels
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-3521
>                 URL: https://issues.apache.org/jira/browse/YARN-3521
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>         Attachments: 0001-YARN-3521.patch
>
>
> In YARN-3413, yarn cluster CLI returns NodeLabel instead of String, we should make the
same change in REST API side to make them consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message