hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3489) RMServerUtils.validateResourceRequests should only obtain queue info once
Date Tue, 21 Apr 2015 06:27:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504437#comment-14504437
] 

Hadoop QA commented on YARN-3489:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12726790/YARN-3489.02.patch
  against trunk revision d52de61.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

                  org.apache.hadoop.yarn.server.resourcemanager.security.TestRMDelegationTokens

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7417//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7417//console

This message is automatically generated.

> RMServerUtils.validateResourceRequests should only obtain queue info once
> -------------------------------------------------------------------------
>
>                 Key: YARN-3489
>                 URL: https://issues.apache.org/jira/browse/YARN-3489
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Jason Lowe
>            Assignee: Varun Saxena
>         Attachments: YARN-3489.01.patch, YARN-3489.02.patch
>
>
> Since the label support was added we now get the queue info for each request being validated
in SchedulerUtils.validateResourceRequest.  If validateResourceRequests needs to validate
a lot of requests at a time (e.g.: large cluster with lots of varied locality in the requests)
then it will get the queue info for each request.  Since we build the queue info this generates
a lot of unnecessary garbage, as the queue isn't changing between requests.  We should grab
the queue info once and pass it down rather than building it again for each request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message