hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3463) Integrate OrderingPolicy Framework with CapacityScheduler
Date Thu, 16 Apr 2015 17:16:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498326#comment-14498326
] 

Wangda Tan commented on YARN-3463:
----------------------------------

Some comments:

LeafQueue:
- activeApplications now becomes orderingPolicy, should we make pendingApplications to use
customized comparator?
- getOrderingPolicy is located in CapacityScheduler, so SchedulerEntity can be FicaSchedulerAppp,
can we make it not use generic type now for simpler?

CapacitySchedulerConfiguration:
- I think we may carefully add ORDERING_POLICY_CONFIG, since this will be a public config.
I understand the reason to add the policy_config is to support policy=fair, config=fair+fifo
usecase, but I'm not sure if we really need that. For now, to satisfy fair scheduling only,
I suggest to support policy only, and the config="fair+fifo" will be set directly, we can
discuss and add configurable items in the future. And since the ordering_policy potentially
could change (the ordering_policy is a new feature and isn't under extensive review), it's
better to add a note to indicate it's a experimental option in the upcoming doc.

CapacityScheduler:
- Why change this?
{code}
-          + " is not empty " + disposableLeafQueue.getApplications().size()
+          + " is not empty " + disposableLeafQueue.getNumActiveApplications()
{code}

TestProportional...Policy:
- Suppress generic warning?
{code}
    OrderingPolicy so = mock(OrderingPolicy.class);
    when(so.getPreemptionIterator()).thenAnswer(new Answer() {
{code}

Javac warning?

> Integrate OrderingPolicy Framework with CapacityScheduler
> ---------------------------------------------------------
>
>                 Key: YARN-3463
>                 URL: https://issues.apache.org/jira/browse/YARN-3463
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Craig Welch
>            Assignee: Craig Welch
>         Attachments: YARN-3463.50.patch, YARN-3463.61.patch, YARN-3463.64.patch, YARN-3463.65.patch,
YARN-3463.66.patch
>
>
> Integrate the OrderingPolicy Framework with the CapacityScheduler



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message