hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3390) Reuse TimelineCollectorManager for RM
Date Wed, 15 Apr 2015 17:01:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14496511#comment-14496511
] 

Sangjin Lee commented on YARN-3390:
-----------------------------------

{quote}
For putIfAbsent and remove, I don't use template method pattern, but let the subclass override
the super class method and invoke it inside the override implementation, because I'm not sure
if we will need pre process or post process, and if we only invoke the process when adding
a new collector. If we're sure about template, I'm okay with the template pattern too.
{quote}
I'm fine with either approach. The main reason I thought of that is I wanted to be clear that
the base implementation of putIfAbsent() and remove() is mandatory (i.e. not optional). Since
we control all of it (base and subclasses), it might not be such a big deal either way.

> Reuse TimelineCollectorManager for RM
> -------------------------------------
>
>                 Key: YARN-3390
>                 URL: https://issues.apache.org/jira/browse/YARN-3390
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-3390.1.patch
>
>
> RMTimelineCollector should have the context info of each app whose entity  has been put



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message