hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3318) Create Initial OrderingPolicy Framework and FifoOrderingPolicy
Date Tue, 14 Apr 2015 16:59:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494396#comment-14494396
] 

Wangda Tan commented on YARN-3318:
----------------------------------

Beyond SchedulerApplicationAttempt which is pending YARN-3361, Few comments on latest patch:

1) CACHED_USED/CACHED_PENDING don't used by anybody, are they pending YARN-3361 as well? 
2) AbstractComparatorOrderingPolicy doesn't handle locks, I suggest to add synchronized lock
to all methods if you think it will only be used in single-thread scenario
3) FifoComparator, it will be used by FairOrderingPolicy as well? If so, better to make it
to a separated class
4) How about call {{getInfo}} to {{getStatusMessage}}, since the "info" is too generic. And
add a comment to indicate it will be used for logger printing.
5) getComparator of AbstractComparatorOrderingPolicy is @VisibleForTest?

> Create Initial OrderingPolicy Framework and FifoOrderingPolicy
> --------------------------------------------------------------
>
>                 Key: YARN-3318
>                 URL: https://issues.apache.org/jira/browse/YARN-3318
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>            Reporter: Craig Welch
>            Assignee: Craig Welch
>         Attachments: YARN-3318.13.patch, YARN-3318.14.patch, YARN-3318.17.patch, YARN-3318.34.patch,
YARN-3318.35.patch, YARN-3318.36.patch, YARN-3318.39.patch, YARN-3318.45.patch, YARN-3318.47.patch,
YARN-3318.48.patch, YARN-3318.52.patch, YARN-3318.53.patch, YARN-3318.56.patch, YARN-3318.57.patch,
YARN-3318.58.patch, YARN-3318.59.patch
>
>
> Create the initial framework required for using OrderingPolicies and an initial FifoOrderingPolicy



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message