hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3286) Cleanup RMNode#ReconnectNodeTransition
Date Wed, 01 Apr 2015 13:36:53 GMT

    [ https://issues.apache.org/jira/browse/YARN-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390553#comment-14390553
] 

Hadoop QA commented on YARN-3286:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12708671/0001-YARN-3286.patch
  against trunk revision 2e79f1c.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7189//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7189//console

This message is automatically generated.

> Cleanup RMNode#ReconnectNodeTransition
> --------------------------------------
>
>                 Key: YARN-3286
>                 URL: https://issues.apache.org/jira/browse/YARN-3286
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.6.0, 2.7.0
>            Reporter: Rohith
>            Assignee: Rohith
>         Attachments: 0001-YARN-3286.patch, YARN-3286-test-only.patch
>
>
> RMNode#ReconnectNodeTransition has messed up for every ReconnectedEvent. This part of
the code can be clean up where we do not require to remove node and add new node every time.
> Supporting to above point, in the issue discussion YARN-3222 mentioned in the comment
[link1|https://issues.apache.org/jira/browse/YARN-3222?focusedCommentId=14339799&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14339799]
and [link2|https://issues.apache.org/jira/browse/YARN-3222?focusedCommentId=14344739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14344739]
> Clean up can do the following things
> # It always remove an old node and add a new node. This is not really required, instead
old node can be updated with new values.
> # RMNode#totalCapability has stale capability after NM is reconnected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message