hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS
Date Mon, 20 Apr 2015 18:33:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503363#comment-14503363

Sangjin Lee commented on YARN-3046:

Sorry my review is late for this [~djp]!

Some high level comments:
- So am I correct in understanding that with this patch it emits events to the timeline service?
Are metrics emitted as well? I didn't see any changes regarding writing metrics to the timeline
service. I might have missed that detail.
- Why not use HierarchicalTimelineEntity for job entity and task entities? If hierarchical
timeline entities don't work for MR jobs and tasks, I don't know where it will. Shouldn't
we try to use it for the MR job/task/etc.?
- For that matter, do we need to think about emitting task attempts, or should we consider
as the next step after this?

One small question:
- JobHistoryEventHandler.java:775: is that change related with this JIRA, or is it something


> [Event producers] Implement MapReduce AM writing some MR metrics to ATS
> -----------------------------------------------------------------------
>                 Key: YARN-3046
>                 URL: https://issues.apache.org/jira/browse/YARN-3046
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Junping Du
>         Attachments: YARN-3046-no-test-v2.patch, YARN-3046-no-test.patch, YARN-3046-v1-rebase.patch,
YARN-3046-v1.patch, YARN-3046-v2.patch, YARN-3046-v3.patch, YARN-3046-v4.patch
> Per design in YARN-2928, select a handful of MR metrics (e.g. HDFS bytes written) and
have the MR AM write the framework-specific metrics to ATS.

This message was sent by Atlassian JIRA

View raw message