hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2740) ResourceManager side should properly handle node label modifications when distributed node label configuration enabled
Date Sat, 18 Apr 2015 00:52:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500975#comment-14500975
] 

Naganarasimha G R commented on YARN-2740:
-----------------------------------------

Thanks for the comments [~wangda], 

bq. I think it's not a big problem, NM doesn't need to know "x" being removed, the logic should
be, NM reports label, and RM allocate according to label, NM should just move on if adding
label failed 
Well IIUC, based on your reply to first point ??prevent admin remove clusterNodeLabel when
distributed enabled?? we need worry about this second point right? as user will not be able
to remove cluster node label
bq. as what we done in YARN-2495. My opinion here is not add extra RM->NM communicate.
As per last discussion in YARN-2495 you had given a concluded as per this [comment |https://issues.apache.org/jira/browse/YARN-2495?focusedCommentId=14358109&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14358109]
that 
{quote}
* Show/log diagnostic in RM (nodes) page and NM page, saying label is invalid. (Need modify
web UI, can be done in a separated task)
* Make the node's labels to be empty, so that applications can continue use it.
{quote}
based on this i mentioned RM->NM communicate/notify would be required as labels are sent
only on change in NM side  and  it will not be able show that there is error in reporting
labels. In btw have raised new jira YARN-3506 for this error handling reported in YARN-2495
Test failure is not related to this patch and will work on {{prevent admin remove clusterNodeLabel
when distributed enabled.}} and resubmit the patch.

> ResourceManager side should properly handle node label modifications when distributed
node label configuration enabled
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2740
>                 URL: https://issues.apache.org/jira/browse/YARN-2740
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>             Fix For: 2.8.0
>
>         Attachments: YARN-2740-20141024-1.patch, YARN-2740.20150320-1.patch, YARN-2740.20150327-1.patch,
YARN-2740.20150411-1.patch, YARN-2740.20150411-2.patch, YARN-2740.20150411-3.patch, YARN-2740.20150417-1.patch
>
>
> According to YARN-2495, when distributed node label configuration is enabled:
> - RMAdmin / REST API should reject change labels on node operations.
> - CommonNodeLabelsManager shouldn't persist labels on nodes when NM do heartbeat.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message