hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dustin Cote (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-2369) Environment variable handling assumes values should be appended
Date Sun, 12 Apr 2015 19:00:13 GMT

     [ https://issues.apache.org/jira/browse/YARN-2369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dustin Cote updated YARN-2369:
------------------------------
    Attachment: YARN-2369-1.patch

This patch gets this working for the scenario outlined in the description with 2 JAVA_HOME
specifications.  I made it so any variable set that doesn't match *PATH* would replace instead
of append.  Any variable that matches *PATH* would continue to be appended to as before. 
I tried it out but am wondering if there's a more complete way to do the white listing of
appendable variables?  I could define them myself somewhere, but that doesn't seem any better
than checking for the presence of the substring PATH.  Any thoughts here?

Also test wise, I'm looking for some unit test suite for env variables that I can add onto
here.  Does one exist?  I'll look myself too, but just in case someone knows offhand.

> Environment variable handling assumes values should be appended
> ---------------------------------------------------------------
>
>                 Key: YARN-2369
>                 URL: https://issues.apache.org/jira/browse/YARN-2369
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: Jason Lowe
>            Assignee: Dustin Cote
>         Attachments: YARN-2369-1.patch
>
>
> When processing environment variables for a container context the code assumes that the
value should be appended to any pre-existing value in the environment.  This may be desired
behavior for handling path-like environment variables such as PATH, LD_LIBRARY_PATH, CLASSPATH,
etc. but it is a non-intuitive and harmful way to handle any variable that does not have path-like
semantics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message