Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B7B117987 for ; Thu, 5 Mar 2015 03:15:39 +0000 (UTC) Received: (qmail 18817 invoked by uid 500); 5 Mar 2015 03:15:39 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 18773 invoked by uid 500); 5 Mar 2015 03:15:39 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 18762 invoked by uid 99); 5 Mar 2015 03:15:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Mar 2015 03:15:38 +0000 Date: Thu, 5 Mar 2015 03:15:38 +0000 (UTC) From: "Zhijie Shen (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3264) [Storage implementation] Create backing storage write interface and a POC only file based storage implementation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348052#comment-14348052 ] Zhijie Shen commented on YARN-3264: ----------------------------------- The patch looks almost good. Two minor issue: 1. Should we still keep TimelineAggregator "abstract"? 2. To be consistent, how about renaming: TimelineServiceWriteResponse -> TimelineWriteResponse, TimelineServiceWriteError ->TimelineWriteResponse, and TimelineServiceWriter(Impl) -> TimelineWriter(Impl) and so on > [Storage implementation] Create backing storage write interface and a POC only file based storage implementation > ----------------------------------------------------------------------------------------------------------------- > > Key: YARN-3264 > URL: https://issues.apache.org/jira/browse/YARN-3264 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Reporter: Vrushali C > Assignee: Vrushali C > Attachments: YARN-3264.001.patch, YARN-3264.002.patch, YARN-3264.003.patch, YARN-3264.004.patch, YARN-3264.005.patch > > > For the PoC, need to create a backend impl for file based storage of entities -- This message was sent by Atlassian JIRA (v6.3.4#6332)