Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8B2EE17EBF for ; Tue, 17 Mar 2015 07:04:43 +0000 (UTC) Received: (qmail 12281 invoked by uid 500); 17 Mar 2015 07:04:42 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 12212 invoked by uid 500); 17 Mar 2015 07:04:42 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 12115 invoked by uid 99); 17 Mar 2015 07:04:42 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2015 07:04:42 +0000 Date: Tue, 17 Mar 2015 07:04:42 +0000 (UTC) From: "zhihai xu (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (YARN-3241) Leading space, trailing space and empty sub queue name may cause MetricsException for fair scheduler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhihai xu updated YARN-3241: ---------------------------- Attachment: YARN-3241.000.patch > Leading space, trailing space and empty sub queue name may cause MetricsException for fair scheduler > ---------------------------------------------------------------------------------------------------- > > Key: YARN-3241 > URL: https://issues.apache.org/jira/browse/YARN-3241 > Project: Hadoop YARN > Issue Type: Bug > Components: scheduler > Reporter: zhihai xu > Assignee: zhihai xu > Attachments: YARN-3241.000.patch > > > Leading space, trailing space and empty sub queue name may cause MetricsException(Metrics source XXX already exists! ) when add application to FairScheduler. > The reason is because QueueMetrics parse the queue name different from the QueueManager. > QueueMetrics use Q_SPLITTER to parse queue name, it will remove Leading space and trailing space in the sub queue name, It will also remove empty sub queue name. > {code} > static final Splitter Q_SPLITTER = > Splitter.on('.').omitEmptyStrings().trimResults(); > {code} > But QueueManager won't remove Leading space, trailing space and empty sub queue name. > This will cause out of sync between FSQueue and FSQueueMetrics. > QueueManager will think two queue names are different so it will try to create a new queue. > But FSQueueMetrics will treat these two queue names as same queue which will create "Metrics source XXX already exists!" MetricsException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)