Return-Path: 
 <yarn-issues-return-51699-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A4A10178D2
	for <apmail-hadoop-yarn-issues-archive@minotaur.apache.org>;
 Tue, 24 Mar 2015 15:04:54 +0000 (UTC)
Received: (qmail 80309 invoked by uid 500); 24 Mar 2015 15:04:54 -0000
Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org
Received: (qmail 80268 invoked by uid 500); 24 Mar 2015 15:04:54 -0000
Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:yarn-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:yarn-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:yarn-issues@hadoop.apache.org>
List-Id: <yarn-issues.hadoop.apache.org>
Reply-To: yarn-issues@hadoop.apache.org
Delivered-To: mailing list yarn-issues@hadoop.apache.org
Received: (qmail 80257 invoked by uid 99); 24 Mar 2015 15:04:54 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Mar 2015 15:04:54 +0000
Date: Tue, 24 Mar 2015 15:04:54 +0000 (UTC)
From: "Junping Du (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12766984.1421109908000.10052.1427209494386@Atlassian.JIRA>
In-Reply-To: <JIRA.12766984.1421109908000@Atlassian.JIRA>
References: <JIRA.12766984.1421109908000@Atlassian.JIRA>
 <JIRA.12766984.1421109908804@arcas>
Subject: [jira] [Commented] (YARN-3040) [Data Model] Make putEntities
 operation be aware of the app's context
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/YARN-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377984#comment-14377984 ] 

Junping Du commented on YARN-3040:
----------------------------------

Some additional comments:
{code}
   <property>
+    <description>The YARN cluster ID.</description>
+    <name>yarn.resourcemanager.cluster-id</name>
+    <value>yarn_cluster</value>
+  </property>
{code}
I would prefer something like "yarn.cluster.id" because this id is for identifying YARN cluster rather than ResourceManager. It should keep consistent across RMs (active and standby) get switch over. Also other names like: RM_CLUSTER_ID, DEFAULT_RM_CLUSTER_ID, we should use YARN_CLUSTER_ID instead.

{code}
@@ -208,7 +211,11 @@ public void testDSShell(boolean haveDomain, String timelineVersion)
     if (timelineVersion.equalsIgnoreCase("v2")) {
       String[] timelineArgs = {
           "--timeline_service_version",
-          "v2"
+          "v2",
+          "--flow",
+          "test_flow_id",
+          "--flow_run",
+          "12345678"
       };
{code}
Can we add a test case that without specifying flow_id and flow_run_id and v2 timeline service still can work? In my understanding, these info will still be optional for applications. So we should make sure these info is nullable in launching applications and other following flows.

> [Data Model] Make putEntities operation be aware of the app's context
> ---------------------------------------------------------------------
>
>                 Key: YARN-3040
>                 URL: https://issues.apache.org/jira/browse/YARN-3040
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Zhijie Shen
>         Attachments: YARN-3040.1.patch, YARN-3040.2.patch, YARN-3040.3.patch
>
>
> Per design in YARN-2928, implement client-side API for handling *flows*. Frameworks should be able to define and pass in all attributes of flows and flow runs to YARN, and they should be passed into ATS writers.
> YARN tags were discussed as a way to handle this piece of information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)