hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3375) NodeHealthScriptRunner.shouldRun() check is performing 3 times for starting NodeHealthScriptRunner
Date Fri, 20 Mar 2015 06:35:38 GMT

    [ https://issues.apache.org/jira/browse/YARN-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370844#comment-14370844
] 

Hadoop QA commented on YARN-3375:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12705561/YARN-3375.patch
  against trunk revision 4e886eb.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7038//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7038//console

This message is automatically generated.

> NodeHealthScriptRunner.shouldRun() check is performing 3 times for starting NodeHealthScriptRunner
> --------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3375
>                 URL: https://issues.apache.org/jira/browse/YARN-3375
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>         Attachments: YARN-3375.patch
>
>
> 1. NodeHealthScriptRunner.shouldRun() check is happening 3 times for starting the NodeHealthScriptRunner.
> {code:title=NodeManager.java|borderStyle=solid}
>     if(!NodeHealthScriptRunner.shouldRun(nodeHealthScript)) {
>       LOG.info("Abey khali");
>       return null;
>     }
> {code}
> {code:title=NodeHealthCheckerService.java|borderStyle=solid}
>     if (NodeHealthScriptRunner.shouldRun(
>         conf.get(YarnConfiguration.NM_HEALTH_CHECK_SCRIPT_PATH))) {
>       addService(nodeHealthScriptRunner);
>     }
> {code}
> {code:title=NodeHealthScriptRunner.java|borderStyle=solid}
>     if (!shouldRun(nodeHealthScript)) {
>       LOG.info("Not starting node health monitor");
>       return;
>     }
> {code}
> 2. If we don't configure node health script or configured health script doesn't execute
permission, NM logs with the below message.
> {code:xml}
> 2015-03-19 19:55:45,713 INFO org.apache.hadoop.yarn.server.nodemanager.NodeManager: Abey
khali
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message