hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohith (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3357) Move TestFifoScheduler to FIFO package
Date Wed, 18 Mar 2015 11:50:39 GMT

    [ https://issues.apache.org/jira/browse/YARN-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367030#comment-14367030
] 

Rohith commented on YARN-3357:
------------------------------

Attaching the patch with following changes
# Moved all the tests from org.apache.hadoop.yarn.server.resourcemanager.TestFifoScheduler
to  org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
# Removed duplicated test which was testing same functionality in both the classes i.e {{testBlackListNodes}}
# Other 2 test classes were using TestFifoScheduler as class name for logging in test. I just
corrected to its own classes.

Kindly review the patch

> Move TestFifoScheduler to FIFO package
> --------------------------------------
>
>                 Key: YARN-3357
>                 URL: https://issues.apache.org/jira/browse/YARN-3357
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: scheduler
>            Reporter: Rohith
>            Assignee: Rohith
>         Attachments: 0001-YARN-3357.patch
>
>
> There are 2 test classes are found for fifo scheduler i.e 
> # org.apache.hadoop.yarn.server.resourcemanager.TestFifoScheduler
> # org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler.
> In these some test cases are common in both that does same functionality has been verified
i.e testBlackListNodes. Tests from package org.apache.hadoop.yarn.server.resourcemanager can
be merged with  package org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo. And
eliminate duplicate tests



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message