hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3349) treat all exceptions as failure in testFSRMStateStoreClientRetry
Date Sun, 15 Mar 2015 10:04:38 GMT

    [ https://issues.apache.org/jira/browse/YARN-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362323#comment-14362323
] 

Hadoop QA commented on YARN-3349:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12704654/YARN-3349.000.patch
  against trunk revision bc9cb3e.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6966//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6966//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6966//console

This message is automatically generated.

> treat all exceptions as failure in testFSRMStateStoreClientRetry
> ----------------------------------------------------------------
>
>                 Key: YARN-3349
>                 URL: https://issues.apache.org/jira/browse/YARN-3349
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: test
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>         Attachments: YARN-3349.000.patch
>
>
> treat all exceptions as failure in testFSRMStateStoreClientRetry.
> Currently the exception "could only be replicated to 0 nodes instead of minReplication
(=1)" is not treated as failure in testFSRMStateStoreClientRetry.
> {code}
>             // TODO 0 datanode exception will not be retried by dfs client, fix
>             // that separately.
>             if (!e.getMessage().contains("could only be replicated" +
>                 " to 0 nodes instead of minReplication (=1)")) {
>                 assertionFailedInThread.set(true);
>              }
> {code}
> With YARN-2820(Retry in FileSystemRMStateStore), we needn't treat this  exception specially.
We can remove the check and treat all exceptions as failure in testFSRMStateStoreClientRetry.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message