hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3345) Add non-exclusive node label RMAdmin CLI/API
Date Wed, 18 Mar 2015 23:03:39 GMT

    [ https://issues.apache.org/jira/browse/YARN-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368089#comment-14368089
] 

Jian He commented on YARN-3345:
-------------------------------

- public/unstable annotations for the newly added records, e.g. SetNodeLabelsAttributesRequest,
NodeLabelAttributes#getAttributes,getNodeLabel
- NodeLabelAttributes -> NodeLabel, so that  AddToClusterNodeLabelsRequest can later on
use the same data structure.
- for node exclusiveness - I think we may use NodeLabel#(get/set)IsExclusive
- “ an un existed node-label=%s” - “non-existing node-label”
- throw YarnException instead of IOException
- below code, how about user wants to set the attributes to be empty
{code}
if (attr.getAttributes().isEmpty()) {
  // simply ignore
  continue;
}
{code}
- add a newInstance method in SetNodeLabelsAttributesResponse and use that 
{code}
SetNodeLabelsAttributesResponse response =
    recordFactory.newRecordInstance(SetNodeLabelsAttributesResponse.class);
{code}
- revert RMNodeLabelsManager change

> Add non-exclusive node label RMAdmin CLI/API
> --------------------------------------------
>
>                 Key: YARN-3345
>                 URL: https://issues.apache.org/jira/browse/YARN-3345
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-3345.1.patch, YARN-3345.2.patch, YARN-3345.3.patch, YARN-3345.4.patch
>
>
> As described in YARN-3214 (see design doc attached to that JIRA), we need add non-exclusive
node label RMAdmin API and CLI implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message