hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3210) [Source organization] Refactor timeline aggregator according to new code organization
Date Mon, 02 Mar 2015 21:34:05 GMT

    [ https://issues.apache.org/jira/browse/YARN-3210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343801#comment-14343801
] 

Zhijie Shen commented on YARN-3210:
-----------------------------------

Thanks Li! Some additional comments

1. Can we rename the member variable name too? And please double check the other member variables
and local variables whose class name has been changed.
{code}
private final TimelineAggregatorsCollection serviceManager;
{code}
{code}
162	    final TimelineAggregatorsCollection serviceManager =
163	        (TimelineAggregatorsCollection) context.getAttribute(
164	            TimelineAggregatorsCollection.AGGREGATOR_COLLECTION_ATTR_KEY);
{code}

2. Per offline discussion this morning, I thought the collection can hold not just app-level
aggregator, right?
{code}
103	        try {
104	          service = new AppLevelTimelineAggregator(appId);
105	          // initialize, start, and add it to the parent service so it can be
106	          // cleaned up when the parent shuts down
{code}

3. Shall we make the order of super call and other call consistent?
{code}
69	  @Override
70	  protected void serviceInit(Configuration conf) throws Exception {
71	    serviceManager.init(conf);
72	    super.serviceInit(conf);
73	  }
74	
75	  @Override
76	  protected void serviceStart() throws Exception {
77	    super.serviceStart();
78	    serviceManager.start();
79	  }
80	
81	  @Override
82	  protected void serviceStop() throws Exception {
83	    // stop the service manager
84	    serviceManager.stop();
85	    super.serviceStop();
86	  }
{code}

> [Source organization] Refactor timeline aggregator according to new code organization
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-3210
>                 URL: https://issues.apache.org/jira/browse/YARN-3210
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Li Lu
>              Labels: refactor
>         Attachments: YARN-3210-022715.patch, YARN-3210-030215.patch
>
>
> We may want to refactor the code of timeline aggregator according to the discussion of
YARN-3166, the code organization for timeline service v2. We need to refactor the code after
we reach an agreement on the aggregator part of YARN-3166. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message