hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3047) [Data Serving] Set up ATS reader with basic request serving structure and lifecycle
Date Wed, 25 Mar 2015 23:06:54 GMT

    [ https://issues.apache.org/jira/browse/YARN-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380988#comment-14380988
] 

Zhijie Shen commented on YARN-3047:
-----------------------------------

Varun, thanks of uploading the new patch and the design doc. Some more comments for the patch
first:

1. The patch cannot apply cleanly.

2. Okay, let's keep it for now, and resolve it later, but can we change the config name to
"yarn.timeline-service.reader.blah-blah"? And we should add an entry in yarn-default.xml.

bq. Anyways I am continuing with separate config for reader as of now. Let me know if you
have a difference in opinion owing to ease in migration."

3. In TestTimelineReaderWebServer, can we check if we can access the info resource when the
server is up?

4. AboutInfo is used in TimelineCollectorWebService too. Can we prevent duplicating this class?

5. TimelineReaderServer only contains one web server, such that it will terminates immediately
as web server threads are set as daemon. It needs to be fixed in some way. I also file a ticket:
HADOOP-11749. See if it can be resolved form HttpServer2.

I'll review the design doc a bit later.

> [Data Serving] Set up ATS reader with basic request serving structure and lifecycle
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-3047
>                 URL: https://issues.apache.org/jira/browse/YARN-3047
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: Timeline_Reader(draft).pdf, YARN-3047.001.patch, YARN-3047.003.patch,
YARN-3047.02.patch, YARN-3047.04.patch
>
>
> Per design in YARN-2938, set up the ATS reader as a service and implement the basic structure
as a service. It includes lifecycle management, request serving, and so on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message