Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37DC717AAC for ; Tue, 17 Feb 2015 08:14:08 +0000 (UTC) Received: (qmail 99377 invoked by uid 500); 17 Feb 2015 08:14:08 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 99333 invoked by uid 500); 17 Feb 2015 08:14:08 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 99318 invoked by uid 99); 17 Feb 2015 08:14:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Feb 2015 08:14:07 +0000 Date: Tue, 17 Feb 2015 08:14:07 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3182) Cleanup switch statement in ApplicationMasterLauncher#handle() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323859#comment-14323859 ] Hudson commented on YARN-3182: ------------------------------ SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #97 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/97/]) YARN-3182. Cleanup switch statement in ApplicationMasterLauncher#handle(). Contributed by Ray Chiang. (ozawa: rev 110cf6b9a3b64cc2159e708967b854f5a419d438) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/ApplicationMasterLauncher.java > Cleanup switch statement in ApplicationMasterLauncher#handle() > -------------------------------------------------------------- > > Key: YARN-3182 > URL: https://issues.apache.org/jira/browse/YARN-3182 > Project: Hadoop YARN > Issue Type: Improvement > Affects Versions: 2.6.0 > Reporter: Ray Chiang > Assignee: Ray Chiang > Priority: Minor > Fix For: 2.7.0 > > Attachments: YARN-3182.001.patch > > > The last case in the switch statement relies on the break coming from the default case instead of having it's own break. It's a bit dangerous for any future code modifications in this section. -- This message was sent by Atlassian JIRA (v6.3.4#6332)