Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 12 Feb 2015 12:30:12 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12773234.1423329180000.25963.1423744212225@Atlassian.JIRA>
In-Reply-To: <JIRA.12773234.1423329180000@Atlassian.JIRA>
References: <JIRA.12773234.1423329180000@Atlassian.JIRA>
 <JIRA.12773234.1423329180332@arcas>
Subject: [jira] [Commented] (YARN-3157) Refactor the exception handling in
 ConverterUtils#to*Id
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318103#comment-14318103 ] 

Hadoop QA commented on YARN-3157:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12698404/YARN-3157.2.patch
  against trunk revision ac8d52b.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6612//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6612//console

This message is automatically generated.

> Refactor the exception handling in ConverterUtils#to*Id
> -------------------------------------------------------
>
>                 Key: YARN-3157
>                 URL: https://issues.apache.org/jira/browse/YARN-3157
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Minor
>         Attachments: YARN-3157.1.patch, YARN-3157.2.patch, YARN-3157.2.patch, YARN-3157.patch, YARN-3157.patch
>
>
> yarn.cmd application -kill application_123
> Format wrong given for application id or attempt. Exception will be thrown to console with out any info
> {quote}
> 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where
> Exception in thread "main" java.util.NoSuchElementException
>         at com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
>         at org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146)
>         at org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205)
>         at org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383)
>         at org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> {quote}
> Need to add catch block for java.util.NoSuchElementException also
> {color:red}./yarn container -status container_e20_1423221031460_0003_01{color}
> Exception in thread "main" java.util.NoSuchElementException
>         at com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
>         at org.apache.hadoop.yarn.api.records.ContainerId.fromString(ContainerId.java:227)
>         at org.apache.hadoop.yarn.util.ConverterUtils.toContainerId(ConverterUtils.java:178)


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)