Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3621110514 for ; Sat, 14 Feb 2015 01:44:13 +0000 (UTC) Received: (qmail 74740 invoked by uid 500); 14 Feb 2015 01:44:13 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 74693 invoked by uid 500); 14 Feb 2015 01:44:13 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 74681 invoked by uid 99); 14 Feb 2015 01:44:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Feb 2015 01:44:13 +0000 Date: Sat, 14 Feb 2015 01:44:12 +0000 (UTC) From: "Robert Kanter (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3041) [Data Model] create the ATS entity/event API MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321124#comment-14321124 ] Robert Kanter commented on YARN-3041: ------------------------------------- Looks good overall. Thanks for picking this up from me; I kept not having time to update it. A few things: - How stringent do we want to be on allowed parent-child relationships? -- There's nothing stopping me from calling {{addChild}} on multiple parents for some {{TimelineEntity}} -- There's nothing stopping me from using {{setChildren}} to bypass the acceptable entities check -- Should {{addChild}} also take care of calling {{child.setParent(this)}}? - I think we should rename {{getAcceptableEntityTypes()}} and {{ACCEPTABLE_ENTITY_TYPES}} to {{getAcceptableChildEntityTypes}} and {{ACCEPTABLE_CHILD_ENTITY_TYPES}}. I wasn't sure what these were until I saw how they were used in the {{HierarchicalTimelineEntity}} class - I believe we discussed this somewhere before and decided that not all Entities need a configuration property - {{info}} should be named {{metadata}} > [Data Model] create the ATS entity/event API > -------------------------------------------- > > Key: YARN-3041 > URL: https://issues.apache.org/jira/browse/YARN-3041 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Reporter: Sangjin Lee > Assignee: Zhijie Shen > Attachments: Data_model_proposal_v2.pdf, YARN-3041.2.patch, YARN-3041.preliminary.001.patch > > > Per design in YARN-2928, create the ATS entity and events API. > Also, as part of this JIRA, create YARN system entities (e.g. cluster, user, flow, flow run, YARN app, ...). -- This message was sent by Atlassian JIRA (v6.3.4#6332)