Return-Path: 
 <yarn-issues-return-46936-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 77FC917383
	for <apmail-hadoop-yarn-issues-archive@minotaur.apache.org>;
 Thu,  5 Feb 2015 21:10:35 +0000 (UTC)
Received: (qmail 23492 invoked by uid 500); 5 Feb 2015 21:10:35 -0000
Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org
Received: (qmail 23443 invoked by uid 500); 5 Feb 2015 21:10:35 -0000
Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:yarn-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:yarn-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:yarn-issues@hadoop.apache.org>
List-Id: <yarn-issues.hadoop.apache.org>
Reply-To: yarn-issues@hadoop.apache.org
Delivered-To: mailing list yarn-issues@hadoop.apache.org
Received: (qmail 23432 invoked by uid 99); 5 Feb 2015 21:10:35 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Feb 2015 21:10:35 +0000
Date: Thu, 5 Feb 2015 21:10:35 +0000 (UTC)
From: "Jian He (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12748356.1413395572000.271477.1423170635175@Atlassian.JIRA>
In-Reply-To: <JIRA.12748356.1413395572000@Atlassian.JIRA>
References: <JIRA.12748356.1413395572000@Atlassian.JIRA>
 <JIRA.12748356.1413395572909@arcas>
Subject: [jira] [Commented] (YARN-2694) Ensure only single node labels
 specified in resource request / host, and node label expression only
 specified when resourceName=ANY
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/YARN-2694?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14308=
002#comment-14308002 ]=20

Jian He commented on YARN-2694:
-------------------------------

few minor comments, looks good overall,

- check if empty too ?
{code}
    if (null =3D=3D exp) {
      return;
    }
{code}
- remove the IOException from the method header
{code}
  private Map<NodeId, Set<String>> buildNodeLabelsMapFromStr(String args)
      throws IOException=20
{code}
- exceed 80 column limit
{code}
private void verifyAddRequestFailed(AMRMClient<ContainerRequest> client, Co=
ntainerRequest request) {
{code}
- Instead of throwing IOException, use precondition check too
{code}
if (labels.size() > 1) {
        String msg =3D String.format("%d labels specified on host=3D%s"
            + ", please note that we do not support specifying multiple"
            + " labels on a single host for now.", labels.size(),
            nodeId.getHost());
        LOG.error(msg);
       =20
{code}
- should the following check empty string too ?
{code}
 if (null =3D=3D req.getNodeLabelExpression()
            && ResourceRequest.ANY.equals(req.getResourceName())) {
{code}
- maybe check =E2=80=9C||=E2=80=9D too ?
{code}
if (labelExp !=3D null && labelExp.contains("&&")) {
{code}

> Ensure only single node labels specified in resource request / host, and =
node label expression only specified when resourceName=3DANY
> -------------------------------------------------------------------------=
----------------------------------------------------------
>
>                 Key: YARN-2694
>                 URL: https://issues.apache.org/jira/browse/YARN-2694
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2694-20141020-1.patch, YARN-2694-20141021-1.pat=
ch, YARN-2694-20141023-1.patch, YARN-2694-20141023-2.patch, YARN-2694-20141=
101-1.patch, YARN-2694-20141101-2.patch, YARN-2694-20150121-1.patch, YARN-2=
694-20150122-1.patch, YARN-2694-20150202-1.patch, YARN-2694-20150203-1.patc=
h, YARN-2694-20150203-2.patch, YARN-2694-20150204-1.patch
>
>
> Currently, node label expression supporting in capacity scheduler is part=
ial completed. Now node label expression specified in Resource Request will=
 only respected when it specified at ANY level. And a ResourceRequest/host =
with multiple node labels will make user limit, etc. computation becomes mo=
re tricky.
> Now we need temporarily disable them, changes include,
> - AMRMClient
> - ApplicationMasterService
> - RMAdminCLI
> - CommonNodeLabelsManager



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)