[ https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318085#comment-14318085 ] 

Tsuyoshi OZAWA commented on YARN-3157:
--------------------------------------

[~bibinchundatt] 

{quote}
For container appattempt and application same issue on similar conditions mentioned in defect happens
{quote}

Yes, I've agreed with you in this point.

{code}
   public static ContainerId toContainerId(String containerIdStr) {
-    return ContainerId.fromString(containerIdStr);
+    try {
+      return ContainerId.fromString(containerIdStr);
+    } catch (NoSuchElementException e) {
+      throw new IllegalArgumentException("Invalid ContainerId: "
+          + containerIdStr, e);
+    }
   }
{code}

My point is: only about "ConverterUtils#toContainerId", I think we should catch NoSuchElementException and raise IllegalArgumentException in ContainerId.fromString instead of ConverterUtils#toContainerId for consistency. Does this make sense?

> Refactor the exception handling in ConverterUtils#to*Id
> -------------------------------------------------------
>
>                 Key: YARN-3157
>                 URL: https://issues.apache.org/jira/browse/YARN-3157
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Minor
>         Attachments: YARN-3157.1.patch, YARN-3157.2.patch, YARN-3157.2.patch, YARN-3157.patch, YARN-3157.patch
>
>
> yarn.cmd application -kill application_123
> Format wrong given for application id or attempt. Exception will be thrown to console with out any info
> {quote}
> 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where
> Exception in thread "main" java.util.NoSuchElementException
>         at com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
>         at org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146)
>         at org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205)
>         at org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383)
>         at org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> {quote}
> Need to add catch block for java.util.NoSuchElementException also
> {color:red}./yarn container -status container_e20_1423221031460_0003_01{color}
> Exception in thread "main" java.util.NoSuchElementException
>         at com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
>         at org.apache.hadoop.yarn.api.records.ContainerId.fromString(ContainerId.java:227)
>         at org.apache.hadoop.yarn.util.ConverterUtils.toContainerId(ConverterUtils.java:178)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)