From yarn-issues-return-47713-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Thu Feb 12 12:09:12 2015 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 578AB109B0 for ; Thu, 12 Feb 2015 12:09:12 +0000 (UTC) Received: (qmail 24743 invoked by uid 500); 12 Feb 2015 12:09:12 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 24698 invoked by uid 500); 12 Feb 2015 12:09:12 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 24685 invoked by uid 99); 12 Feb 2015 12:09:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Feb 2015 12:09:12 +0000 Date: Thu, 12 Feb 2015 12:09:12 +0000 (UTC) From: "Tsuyoshi OZAWA (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3157) Refactor the exception handling in ConverterUtils#to*Id MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318085#comment-14318085 ] Tsuyoshi OZAWA commented on YARN-3157: -------------------------------------- [~bibinchundatt] {quote} For container appattempt and application same issue on similar conditions mentioned in defect happens {quote} Yes, I've agreed with you in this point. {code} public static ContainerId toContainerId(String containerIdStr) { - return ContainerId.fromString(containerIdStr); + try { + return ContainerId.fromString(containerIdStr); + } catch (NoSuchElementException e) { + throw new IllegalArgumentException("Invalid ContainerId: " + + containerIdStr, e); + } } {code} My point is: only about "ConverterUtils#toContainerId", I think we should catch NoSuchElementException and raise IllegalArgumentException in ContainerId.fromString instead of ConverterUtils#toContainerId for consistency. Does this make sense? > Refactor the exception handling in ConverterUtils#to*Id > ------------------------------------------------------- > > Key: YARN-3157 > URL: https://issues.apache.org/jira/browse/YARN-3157 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager > Affects Versions: 2.6.0 > Reporter: Bibin A Chundatt > Assignee: Bibin A Chundatt > Priority: Minor > Attachments: YARN-3157.1.patch, YARN-3157.2.patch, YARN-3157.2.patch, YARN-3157.patch, YARN-3157.patch > > > yarn.cmd application -kill application_123 > Format wrong given for application id or attempt. Exception will be thrown to console with out any info > {quote} > 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where > Exception in thread "main" java.util.NoSuchElementException > at com.google.common.base.AbstractIterator.next(AbstractIterator.java:75) > at org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146) > at org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205) > at org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383) > at org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84) > {quote} > Need to add catch block for java.util.NoSuchElementException also > {color:red}./yarn container -status container_e20_1423221031460_0003_01{color} > Exception in thread "main" java.util.NoSuchElementException > at com.google.common.base.AbstractIterator.next(AbstractIterator.java:75) > at org.apache.hadoop.yarn.api.records.ContainerId.fromString(ContainerId.java:227) > at org.apache.hadoop.yarn.util.ConverterUtils.toContainerId(ConverterUtils.java:178) -- This message was sent by Atlassian JIRA (v6.3.4#6332)