From yarn-issues-return-46666-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Wed Feb 4 02:36:40 2015 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5CABE179D2 for ; Wed, 4 Feb 2015 02:36:40 +0000 (UTC) Received: (qmail 11451 invoked by uid 500); 4 Feb 2015 02:36:35 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 11405 invoked by uid 500); 4 Feb 2015 02:36:35 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 11394 invoked by uid 99); 4 Feb 2015 02:36:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Feb 2015 02:36:35 +0000 Date: Wed, 4 Feb 2015 02:36:34 +0000 (UTC) From: "Tsuyoshi OZAWA (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3058) Fix error msg of tokens activation delay configuration MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304531#comment-14304531 ] Tsuyoshi OZAWA commented on YARN-3058: -------------------------------------- +1 > Fix error msg of tokens activation delay configuration > ------------------------------------------------------ > > Key: YARN-3058 > URL: https://issues.apache.org/jira/browse/YARN-3058 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Yi Liu > Assignee: Yi Liu > Priority: Minor > Attachments: YARN-3058.001.patch > > > {code} > this.rollingInterval = conf.getLong( > YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS, > YarnConfiguration.DEFAULT_RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS) * 1000; > ... > this.activationDelay = > (long) (conf.getLong(YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS, > YarnConfiguration.DEFAULT_RM_NM_EXPIRY_INTERVAL_MS) * 1.5); > ... > if (rollingInterval <= activationDelay * 2) { > throw new IllegalArgumentException( > YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS > + " should be more than 2 X " > + YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS); > } > {code} > The error msg should be > {code} > YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS > + " should be more than 3 X " > + YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS); > {code} > Also It's {{3 X}} instead of {{2 X}}, since it's multiplied by *1.5*. > There are few other places having same issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)